Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text for sandbox in replCommand #10493

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Conversation

Sdywolf
Copy link
Contributor

@Sdywolf Sdywolf commented Oct 30, 2024

This PR modifies behaviour or interface

Fix #10482

Text provided by Setup.hs repl --help contained outdated information concerning sandbox, which have now been removed.

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is user-visible (granting, not very, but it is help text) and as such probably requires a changelog entry, although it's not major. Also it's probably worth backporting.

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 30, 2024
@ulysses4ever
Copy link
Collaborator

I'm not sure about the changelog but since technically it is a visible change and there's a voice for it, sure...

@ulysses4ever
Copy link
Collaborator

Changelogs are described here btw: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#changelog

@geekosaur
Copy link
Collaborator

I'm not sure about the changelog but since technically it is a visible change and there's a voice for it, sure...

Yeh, it's borderline, but it is user-visible. Maybe someone else should speak up yea/nay.

@Sdywolf
Copy link
Contributor Author

Sdywolf commented Oct 30, 2024

Thx for reminding me. I will check CONTRIBUTING.md and add changelog entry.

@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Oct 30, 2024
@mergify mergify bot merged commit 9e2b2db into haskell:master Nov 2, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.12 attention: needs-backport 3.14 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup.hs repl --help contains outdated descriptions for sandbox
3 participants