Duplicate project import as a warning only #10933
Conversation
philderbeast
force-pushed
the
fix/y-fork-project-import-warning-only
branch
from
16a11bd to
95ec86a
Compare
| -- NOTE: Reverse the warnings so they are in line number order. | ||
| <&> \case ProjectParseOk ws x -> ProjectParseOk (reverse ws) x; x -> x | ||
| parseProject rootPath cacheDir httpTransport verbosity configToParse = do | ||
| let (dir, projectFileName) = splitFileName rootPath |
There was a problem hiding this comment.
It'd be preferable to not change layout/identation without a real need, I think.
There was a problem hiding this comment.
I strive for minimal diffs. In this situation, I was rebasing something older and it made the merge conflict resolution easier this way.
I actually prefer the way it was before the latest commit, with the = do on the same line rather than do by itself on its own line. This also has less indentation.
If you're OK with the way it is, then I'd like to keep it that way, the way it was, one commit before the last commit.
There was a problem hiding this comment.
I'm a little surprised that fourmolu doesn't always normalize.
There was a problem hiding this comment.
Or it could have been I used a more recent version of fourmolu at some stage.
philderbeast
force-pushed
the
fix/y-fork-project-import-warning-only
branch
from
95ec86a to
f108389
Compare
- Add Y-forking import test - A test for detecting when the same config is imported via many different paths - Error on duplicate imports - Do the filtering in duplicateImportMsg - Use duplicateImportMsg for cycles too - Add haddocks to IORef parameter - Add changelog entry - Use ordNub instead of nub - Use NubList - Share implement of duplicate and cyclical messages - Update expectation for non-cyclical duplicate import - Only show a warning - Add woops project with a time cost - Use noticeDoc instead of warn - Render duplicate imports - Add Ord instance for Dupes, sort on dupesNormLocPath - Fixups after rebase - Satisfy hlint - Remove -XMultiWayIf - Remove mention of yops from the changelog - Satisfy fix-whitespace - Test with a time cost of duplicate imports
philderbeast
force-pushed
the
fix/y-fork-project-import-warning-only
branch
from
f108389 to
115fcd2
Compare
philderbeast
force-pushed
the
fix/y-fork-project-import-warning-only
branch
from
c230d20 to
b61e031
Compare
Pretty much the same as #9933 but gives a warning instead of an error when duplicate imports that are not cyclical are detected. I did this work in Oct 2024 but didn't raise a pull request for it then.
significance: significantin the changelog file.