-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify "configure" messages from Cabal #9476
Conversation
I used template A because error messages are user-facing. I'm not sure how to test these though, as the only way I know to trigger them is a possible cabal-install bug suffered by @Kleidukos around a week ago. |
I have this bug when using cabal-head but not a released version. Thanks for handling this @geekosaur |
Sadly I haven't fixed the actual bug, just made the error message a little less confusing. I assume there's a mismatch between what |
BTW @Kleidukos can you file a bug about your error so we have a record of it? I may or may not be able to get to it this weekend and I'll be gone on Monday. AFAICT you only mentioned it on Matrix. |
LGTM, is |
It's used in a few other places (mostly comments), and it could be |
831616e
to
e3796df
Compare
I still don't see a bug corresponding to this, and have no idea whether the original problem still exists, nor how I would go about testing this. |
@geekosaur do you have a plan for this? SHould it be turned into non-draft? |
I completely missed this. I'll see if it's still a thing. |
As far as I'm concerned it's ready to go. But all it does is change some messaging, since Cabal confusingly tells you that you need to reconfigure (which is strictly correct, but if you're using cabal-install then "reconfigure" means something else entirely). |
Co-authored-by: Javier Sagredo <[email protected]>
* clarify "configure" messages from Cabal * add changelog * Apply suggestions from code review Co-authored-by: Javier Sagredo <[email protected]> --------- Co-authored-by: Javier Sagredo <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Template Α: This PR modifies
cabal
behaviourInclude the following checklist in your PR: