Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for #9799 #9805

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Add tests for #9799 #9805

merged 1 commit into from
Apr 17, 2024

Conversation

alt-romes
Copy link
Collaborator

Add tests for #9799 about freeze qualifying all packages with 'any' constraint scope.

@alt-romes
Copy link
Collaborator Author

@grayjay pinging for your review.

Comment on lines 1 to 5
# Revision history for T9799

## 0.1.0.0 -- YYYY-mm-dd

* First version. Released on an unsuspecting world.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the changelogs be removed to simplify the test packages?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few changelogs:

cabal-testsuite/PackageTests/NewFreeze/T9799a/repo/libA-0.1.0.0/CHANGELOG.md
cabal-testsuite/PackageTests/NewFreeze/T9799a/repo/libA-0.2.0.0/CHANGELOG.md
cabal-testsuite/PackageTests/NewFreeze/T9799b/repo/libA-0.1.0.0/CHANGELOG.md
cabal-testsuite/PackageTests/NewFreeze/T9799b/repo/libA-0.2.0.0/CHANGELOG.md

cabal-testsuite/PackageTests/Freeze/T9799a/cabal.test.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/src/None.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/src/None.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/cabal.test.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799a/cabal.test.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/cabal.test.hs Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@alt-romes alt-romes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed your review @grayjay. Should be good to go now.

cabal-testsuite/PackageTests/Freeze/T9799a/cabal.test.hs Outdated Show resolved Hide resolved
Comment on lines 1 to 5
# Revision history for T9799

## 0.1.0.0 -- YYYY-mm-dd

* First version. Released on an unsuspecting world.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

cabal-testsuite/PackageTests/Freeze/T9799b/src/None.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799a/cabal.test.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/cabal.test.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/src/None.hs Outdated Show resolved Hide resolved
cabal-testsuite/PackageTests/Freeze/T9799b/cabal.test.hs Outdated Show resolved Hide resolved
@alt-romes alt-romes force-pushed the wip/romes/9799-2 branch 2 times, most recently from 97b97d9 to a85ed9b Compare April 15, 2024 13:06
Copy link
Collaborator

@grayjay grayjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is ready, except for one comment.

@alt-romes
Copy link
Collaborator Author

Done. Thanks @grayjay.

@alt-romes alt-romes added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Apr 15, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 17, 2024
Add tests for haskell#9799 about freeze qualifying all packages with 'any'
constraint scope.
@mergify mergify bot merged commit d5f59e7 into haskell:master Apr 17, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal-install: cmd/freeze cabal-install: solver merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants