Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8141 Don't refer to 'custom-setup' as 'optional' #9905

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Fix #8141 Don't refer to 'custom-setup' as 'optional' #9905

merged 2 commits into from
Apr 21, 2024

Conversation

mpilgrem
Copy link
Collaborator

Also uses 'stanza' consistently in that context.

See #8141.

  • Patches conform to the coding conventions. Not applicable.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). Not applicable.

@mpilgrem
Fix #8141 Don't refer to 'custom-setup' as 'optional'
2e8d728 
Also uses 'stanza' consistently in that context.
@mpilgrem mpilgrem requested a review from Mikolaj April 17, 2024 20:16
ulysses4ever
ulysses4ever approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how consistent we are w.r.t. section vs. stanza in general, but I particularly like wording of the first of the three hunks in this diff (the required for build-type Custom bit).

@mpilgrem mpilgrem removed the request for review from Mikolaj April 19, 2024 15:53
@mpilgrem mpilgrem added the merge me Tell Mergify Bot to merge label Apr 19, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 21, 2024
@mergify mergify bot merged commit 0863c2b into master Apr 21, 2024
15 checks passed
@mergify mergify bot deleted the fix8141 branch April 21, 2024 16:30
@ulysses4ever
Copy link
Collaborator

documentation fix -- backporting

@ulysses4ever
Copy link
Collaborator

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jun 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@geekosaur geekosaur geekosaur approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpilgrem @ulysses4ever @geekosaur