Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release preparations for 2.0 #299

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Release preparations for 2.0 #299

merged 4 commits into from
Sep 16, 2024

Conversation

sgraf812
Copy link
Collaborator

I mostly completed the ChangeLog from looking at this list.

If someone would give me the necessary hackage credentials (user sgraf812), I would be happy to do the hackage release.
I would just use nix run nixpkgs#hkgr -- publish to do so. Or is there some documented procedure one should follow for releases? At any rate, we should document the procedure. Perhaps in CONTRIBUTING.rst?

@sgraf812 sgraf812 added this to the 2.0 milestone Sep 16, 2024
@Ericson2314
Copy link
Collaborator

happy/doc/introduction.rst

Lines 147 to 156 in 652c4ca

Current Maintainers
~~~~~~~~~~~~~~~~~~~
- Andreas Abel (@andreasabel)
- Vladislav Zavialov (@int-index)
- John Ericson (@Ericson2314)
- Simon Marlow (@simonmar)
do you want to be an official maintainer? :)

@sgraf812
Copy link
Collaborator Author

do you want to be an official maintainer? :)

I would be honored to, and added myself to the list :) 🎉

Copy link
Collaborator

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @int-index or @andreasabel signs off on this, I'll give @sgraf812 the haddock hackage perms :)

@int-index
Copy link
Collaborator

If @int-index or @andreasabel signs off on this, I'll give @sgraf812 the haddock perms :)

Please do!

@Ericson2314 Ericson2314 merged commit 16b576b into master Sep 16, 2024
26 checks passed
@Ericson2314 Ericson2314 deleted the wip/prepare-2.0 branch September 16, 2024 19:06
@Ericson2314
Copy link
Collaborator

Hackage perms granted! :)

@sgraf812
Copy link
Collaborator Author

Thanks :) I'll wait for another 9 hours to give @andreasabel a chance to react before doing the release.

@andreasabel
Copy link
Member

Thanks for all the good work, @sgraf812 !

I did local tests of cabal build, cabal test, cabal install, and using the new Happy for building Agda and other projects.

Could you update the release candidate on hackage (https://hackage.haskell.org/package/happy-2.0/candidate) before pressing the final button? The current one is

Uploaded by int_index at 2024-02-03T14:08:09Z

@sgraf812
Copy link
Collaborator Author

sgraf812 commented Sep 17, 2024

Here's a package candidate for happy-lib: https://hackage.haskell.org/package/happy-lib-2.0/candidate

And the one for happy: https://hackage.haskell.org/package/happy-2.0/candidate

Shall I do cabal gen-bounds as suggested? Also the missing documentation seems strange (I had uploaded it as well)

@andreasabel
Copy link
Member

Reading the changelog in another context (on Hackage), I found a typo.

Here's a package candidate for happy-lib: hackage.haskell.org/package/happy-lib-2.0/candidate

Thanks!

Atm, you are the sole maintainer, this is probably not intended:

Package maintainers
sgraf812

Shall I do cabal gen-bounds as suggested?

Na, I would ignore this.
Let's wait for real breakage, then one can still place upper bounds via Hackage revisions.

Also the missing documentation seems strange (I had uploaded it as well)

The happy-lib does have the documentation.
Executables usually do not have any documentation, so this looks alright, if you ask me.
(In contrast, Agda is both an executable and a library, so it has documentation.)

@sgraf812
Copy link
Collaborator Author

Atm, you are the sole maintainer, this is probably not intended:

Thanks for pointing me to the link where I could change it.

The happy-lib does have the documentation.

That was due to an earlier experiment on my part where I simply made the main component expose all modules directly and deleted all sublibraries (apologies, should have reverted). The latter step was sadly necessary to see the full docs, which seems like a no go after the discussion in #288.

I just re-uploaded the candidate with the state where we have multiple private libraries and after fixing the ChangeLog.

I'm rather reluctant to get rid of the private libraries again (#288), so let's just release as-is and reupload docs when cabal has sorted out the situation wrt. merging documentation of multiple private sublibraries (haskell/cabal#10368). I honestly do not expect much use of happy-lib anyway, and the few users that we attract are likely experts.

A quick glance at https://hackage.haskell.org/package/happy-lib-2.0/candidate and a nod would be appreciated.

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! (except that the typo still seems to plague the candidates).

@sgraf812
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants