-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release preparations for 2.0 #299
Conversation
Lines 147 to 156 in 652c4ca
|
I would be honored to, and added myself to the list :) 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @int-index or @andreasabel signs off on this, I'll give @sgraf812 the haddock hackage perms :)
Please do! |
Hackage perms granted! :) |
Thanks :) I'll wait for another 9 hours to give @andreasabel a chance to react before doing the release. |
Thanks for all the good work, @sgraf812 ! I did local tests of Could you update the release candidate on hackage (https://hackage.haskell.org/package/happy-2.0/candidate) before pressing the final button? The current one is
|
Here's a package candidate for And the one for Shall I do |
Reading the changelog in another context (on Hackage), I found a typo.
Thanks! Atm, you are the sole maintainer, this is probably not intended:
Na, I would ignore this.
The |
Thanks for pointing me to the link where I could change it.
That was due to an earlier experiment on my part where I simply made the main component expose all modules directly and deleted all sublibraries (apologies, should have reverted). The latter step was sadly necessary to see the full docs, which seems like a no go after the discussion in #288. I just re-uploaded the candidate with the state where we have multiple private libraries and after fixing the ChangeLog. I'm rather reluctant to get rid of the private libraries again (#288), so let's just release as-is and reupload docs when A quick glance at https://hackage.haskell.org/package/happy-lib-2.0/candidate and a nod would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! (except that the typo still seems to plague the candidates).
Thanks! Released as https://hackage.haskell.org/package/happy-lib-2.0 and https://hackage.haskell.org/package/happy-2.0. |
I mostly completed the ChangeLog from looking at this list.
If someone would give me the necessary hackage credentials (user sgraf812), I would be happy to do the hackage release.
I would just use
nix run nixpkgs#hkgr -- publish
to do so. Or is there some documented procedure one should follow for releases? At any rate, we should document the procedure. Perhaps inCONTRIBUTING.rst
?