Fix #335: error out on '<$>' in semantic action code #349
+61
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraf812
reviewed
Jan 14, 2026
Collaborator
sgraf812
left a comment
sgraf812
left a comment
There was a problem hiding this comment.
Great, LGTM! Modulo uncertainty of whether it's <$$> or <\$>...
Member
Author
Member
Author
|
@sgraf812 : Shall I release this? |
Collaborator
|
Changelogs look good to me and I could build the branch with tests, so all good! Please remember to push a tag after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sgraf812 I think I implemented what you suggested.
TODO:
Closes #335.
<$>in semantic actions #335