-
-
Notifications
You must be signed in to change notification settings - Fork 153
Bump libraries to latest version #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updating UniFi Network Server to version 9.1.119
""" WalkthroughThe Dockerfile for the UniFi add-on was updated to install newer patch versions of the Changes
Sequence Diagram(s)Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
unifi/Dockerfile (1)
19-22
: Consider adding checksum verification for the downloaded package
Currently the.deb
is installed without integrity checks. To guard against tampering, add a SHA256 verification or GPG signature validation. For example:RUN \ curl -J -L -o /tmp/unifi.deb "https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb" \ + && curl -sSL https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb.sha256 | sha256sum -c - \ && dpkg --install /tmp/unifi.deb \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
unifi/Dockerfile
(1 hunks)
🔇 Additional comments (2)
unifi/Dockerfile (2)
20-20
: Version bump to 9.1.119 looks correct
The download URL has been updated from9.0.114
to9.1.119
, matching the new release.
20-20
:✅ Verification successful
Verify the download URL is reachable
Ensure the new URL returns HTTP 200 and hasn’t been moved or renamed upstream. You can verify with:Expected output:
HTTP/1.1 200 OK
🏁 Script executed:
#!/usr/bin/env bash curl -I -s https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb | head -n 1Length of output: 91
Download URL verified
The URLhttps://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb
returnsHTTP/2 200
, so it’s reachable and no further action is needed.
binutils to v11
Libcap2 to latest version
This reverts commit 4ccc276.
Bump version to 9.1.120
This reverts commit e570bde.
Bump version to 9.1.120
This reverts commit e570bde.
Sorry Frenck... wanted to make new changes in a separate PR, but it keeps putting it in the same PR. |
Closing as this still contains multiple bumps. I'll create some PRs to move forward. ../Frenck |
Updating libraries libcap2 and binutils to latest version.
Proposed Changes
Related Issues
Summary by CodeRabbit
Summary by CodeRabbit