Skip to content

Bump libraries to latest version #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

renewoensdregt
Copy link
Contributor

@renewoensdregt renewoensdregt commented Apr 25, 2025

Updating libraries libcap2 and binutils to latest version.

Proposed Changes

Related Issues

(Github link to related issues or pull requests)

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Upgraded system packages for improved stability and security.
    • Applied minor package updates to enhance system reliability.
    • Updated Unifi package to a newer version for improved performance.
    • Updated system components to newer patch versions for better security.

Updating UniFi Network Server to version 9.1.119
Copy link

coderabbitai bot commented Apr 25, 2025

"""

Walkthrough

The Dockerfile for the UniFi add-on was updated to install newer patch versions of the binutils and libcap2 packages, changing from binutils=2.34-6ubuntu1.9 to binutils=2.34-6ubuntu1.11 and from libcap2=1:2.32-1ubuntu0.1 to libcap2=1:2.32-1ubuntu0.2. No other installation steps, dependencies, or cleanup commands were changed.

Changes

File(s) Change Summary
unifi/Dockerfile Updated package versions: binutils from 2.34-6ubuntu1.9 to 2.34-6ubuntu1.11, libcap2 from 1:2.32-1ubuntu0.1 to 1:2.32-1ubuntu0.2

Sequence Diagram(s)

Suggested labels

dependencies, minor

Suggested reviewers

  • frenck

Poem

A patch here, a patch there,
Binutils and libcap2 with care.
UniFi builds with versions new,
Fresh updates, steady and true,
Rabbits hopping, updates due! 🐇✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e570bde and 0b8c72b.

📒 Files selected for processing (1)
  • unifi/Dockerfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • unifi/Dockerfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
unifi/Dockerfile (1)

19-22: Consider adding checksum verification for the downloaded package
Currently the .deb is installed without integrity checks. To guard against tampering, add a SHA256 verification or GPG signature validation. For example:

 RUN \
     curl -J -L -o /tmp/unifi.deb "https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb" \
+    && curl -sSL https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb.sha256 | sha256sum -c - \
     && dpkg --install /tmp/unifi.deb \
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44a78ea and 4ccc276.

📒 Files selected for processing (1)
  • unifi/Dockerfile (1 hunks)
🔇 Additional comments (2)
unifi/Dockerfile (2)

20-20: Version bump to 9.1.119 looks correct
The download URL has been updated from 9.0.114 to 9.1.119, matching the new release.


20-20:

✅ Verification successful

Verify the download URL is reachable
Ensure the new URL returns HTTP 200 and hasn’t been moved or renamed upstream. You can verify with:

Expected output: HTTP/1.1 200 OK


🏁 Script executed:

#!/usr/bin/env bash
curl -I -s https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb | head -n 1

Length of output: 91


Download URL verified
The URL https://dl.ui.com/unifi/9.1.119/unifi_sysvinit_all.deb returns HTTP/2 200, so it’s reachable and no further action is needed.

binutils to v11
Libcap2 to latest version
@renewoensdregt renewoensdregt changed the title Bump version to 9.1.119 Bump libraries to latest version Apr 25, 2025
@renewoensdregt renewoensdregt requested a review from frenck April 25, 2025 18:48
renewoensdregt added 2 commits April 25, 2025 21:07
Bump version to 9.1.120
@renewoensdregt renewoensdregt marked this pull request as draft April 25, 2025 19:12
renewoensdregt added 2 commits April 25, 2025 21:19
Bump version to 9.1.120
@renewoensdregt renewoensdregt marked this pull request as ready for review April 25, 2025 19:34
@renewoensdregt
Copy link
Contributor Author

Sorry Frenck... wanted to make new changes in a separate PR, but it keeps putting it in the same PR.

@frenck
Copy link
Member

frenck commented May 11, 2025

Closing as this still contains multiple bumps.

I'll create some PRs to move forward.

../Frenck

@frenck frenck closed this May 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants