⬆️ Upgrades UniFi Network Application to 9.1.120 #561
Conversation
WalkthroughThe Dockerfile for the UniFi add-on was updated to install a newer version of the UniFi software. The download URL for the UniFi Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
unifi/Dockerfile (1)
19-21:❓ Verification inconclusive
Parameterize UniFi version and strengthen download reliability
Hardcoding the version in the
curlURL (line 20) requires manual edits for each upgrade. Consider introducing a build argument to DRY up the version number and swap to more robustcurlflags. Example diff:+ARG UNIFI_VERSION=9.1.120 ... - && curl -J -L -o /tmp/unifi.deb \ - "https://dl.ui.com/unifi/9.1.120/unifi_sysvinit_all.deb" \ + && curl -fSL -o /tmp/unifi.deb \ + "https://dl.ui.com/unifi/${UNIFI_VERSION}/unifi_sysvinit_all.deb" \
-fSLwill fail on HTTP errors and follow redirects, ensuring your build stops if the package isn’t found.- You can then bump
UNIFI_VERSIONat the top of the Dockerfile for future upgrades.Finally, verify that the URL resolves and that the downloaded package’s checksum matches the official release:
🏁 Script executed:
#!/bin/bash # Verify HTTP status curl -fsSLI "https://dl.ui.com/unifi/9.1.120/unifi_sysvinit_all.deb" # Example SHA256 check (replace with actual value) echo "<SHA256_SUM> /tmp/unifi.deb" | sha256sum -c -Length of output: 806
Parameterize UniFi version and strengthen download reliability
File:
unifi/Dockerfile
- Define a build argument at the top:
ARG UNIFI_VERSION=9.1.120- Update the download step to use
-fSLand the build arg:- && curl -J -L -o /tmp/unifi.deb \ - "https://dl.ui.com/unifi/9.1.120/unifi_sysvinit_all.deb" \ + && curl -fSL -o /tmp/unifi.deb \ + "https://dl.ui.com/unifi/${UNIFI_VERSION}/unifi_sysvinit_all.deb" \The HTTP status check returned
200 OK, confirming that the URL is valid. However,sha256sumwasn’t available in this environment—please verify the downloaded package’s checksum in your CI or local build before releasing:curl -fsSLI "https://dl.ui.com/unifi/${UNIFI_VERSION}/unifi_sysvinit_all.deb" echo "<OFFICIAL_SHA256_SUM> /tmp/unifi.deb" | sha256sum -c -
|
Hi it seems this is failing for the following error "Error! This pull request does not contain any of the valid labels: ['breaking-change', 'bugfix', 'documentation', 'enhancement', 'refactor', 'performance', 'new-feature', 'maintenance', 'ci', 'dependencies', 'translations']" Can someone provide a way to put a label on this PR such as "maintenance"? |
|
Closing as a duplicate of #560 |
Release notes: https://community.ui.com/releases/UniFi-Network-Application-9-1-120/a5e88ae2-3c44-420a-bebb-5120bf2288b2
Summary by CodeRabbit