Skip to content

feat: Support latest version of boto3 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

mrtmm
Copy link

@mrtmm mrtmm commented Apr 22, 2025

Include the request_checksum_calculation config option to make sure backups can be uploaded to s3 with boto3 >= 1.37.34.

@mrtmm mrtmm force-pushed the fix-uploads branch 3 times, most recently from a4dc505 to 001df89 Compare April 24, 2025 06:37
@mrtmm mrtmm requested a review from fghaas April 24, 2025 06:51
CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## Unreleased

* [Enhancement] Support latest versions of boto3; include the `request_checksum_calculation` setting for s3 client.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's particularly important what the internal configuration option name for the S3 client is; rather, the changelog should reflect the new config option that this plugin supports. Thus:

Suggested change
* [Enhancement] Support latest versions of boto3; include the `request_checksum_calculation` setting for s3 client.
* [Enhancement] Support latest versions of boto3; include the `BACKUP_S3_REQUEST_CHECKSUM_CALCULATION` configuration option.
Defaults to the value of `S3_REQUEST_CHECKSUM_CALCULATION` as set by the `s3` plugin.

Include the `request_checksum_calculation` config option to make
sure backups can be uploaded to s3 with boto3 >= 1.37.34.
@mrtmm mrtmm merged commit e059917 into hastexo:main Apr 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants