Skip to content

feat: Support latest version of boto3 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

mrtmm
Copy link

@mrtmm mrtmm commented Apr 22, 2025

Include the request_checksum_calculation config option to support boto3 >= 1.37.34.

@mrtmm mrtmm force-pushed the fix-uploads branch 2 times, most recently from b2fd1fa to c5ca687 Compare April 24, 2025 06:40
@mrtmm mrtmm requested a review from fghaas April 24, 2025 06:51
fghaas
fghaas previously approved these changes Apr 24, 2025
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fghaas fghaas dismissed their stale review April 24, 2025 07:18

Just a sec, missed a small bit

CHANGELOG.md Outdated
## Unreleased

* [Enhancement] Support latest version of boto3; include the
`request_checksum_calculation` config option.
Copy link
Contributor

@fghaas fghaas Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog entry doesn't reflect the correct name of the config option; it should say S3_REQUEST_CHECKSUM_CALCULATION instead.

Include the request_checksum_calculation config option to support
boto3 >= 1.37.34.
@mrtmm mrtmm merged commit 78ddf66 into hastexo:main Apr 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants