Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the WeAct Studio BlackPill AT32F403ACGx board to the TinyUSB library, porting the board configuration from a previous pull request (#2839).
- Adds new board configuration files for the WeAct BlackPill
- Refactors button handling to support board-specific pull resistor configurations
- Updates existing AT_START_F403A board configuration to use the new button abstraction
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hw/bsp/at32f403a_407/family.c | Updates button initialization and reading to use board-specific constants |
| hw/bsp/at32f403a_407/boards/at_start_f403a/board.h | Adds button pull resistor configuration and updates active state |
| hw/bsp/at32f403a_407/boards/at32f403a_weact_blackpill/board.mk | Makefile configuration for WeAct BlackPill board |
| hw/bsp/at32f403a_407/boards/at32f403a_weact_blackpill/board.h | Header file defining pins, GPIO settings, and hardware configuration |
| hw/bsp/at32f403a_407/boards/at32f403a_weact_blackpill/board.cmake | CMake configuration for WeAct BlackPill board |
rhgndf
commented
Aug 10, 2025
| #define BUTTON_PORT GPIOA | ||
| #define BUTTON_PIN GPIO_PINS_0 | ||
| #define BUTTON_STATE_ACTIVE 0 | ||
| #define BUTTON_PULL GPIO_PULL_DOWN |
Contributor
Author
There was a problem hiding this comment.
don't have the board to test, not sure if it works, best guess based on: https://github.com/RT-Thread-Studio/sdk-bsp-at32f403a-at-start/blob/main/documents/AT_START_F403A_V1.2_SCH.pdf
rhgndf
force-pushed
the
at32f403a_weact_blackpill
branch
3 times, most recently
from
370dff3 to
f39882e
Compare
rhgndf
force-pushed
the
at32f403a_weact_blackpill
branch
from
f39882e to
24e596b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Port the board from #2839 to upstream
Additional context
https://github.com/WeActStudio/WeActStudio.BlackPill