examples/device/*_freertos: expand stack size when needed #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All four of these examples immediately crashed on stack overflow when connected, at least on a FRDM_K64F board. In 46fd822 the default freertos stack size was increased, but _only_ for stm32? Perhaps either all platform examples need the default increased, rather than increasing the problem task stacks as is done here. Signed-off-by: Karl Palsson <[email protected]>
|
did it crash when you enable LOG=1,2 ? |
|
Yes, and sure, maybe it's "not required" but surely the demos should just work ? |
|
if it only crash when you enabled LOG=2 (CFG_TUSB_DEBUG=2) (printf does consume some stack), then we should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All four of these examples immediately crashed on stack overflow when connected, at least on a FRDM_K64F board.
In 46fd822 the default freertos stack size was increased, but only for stm32? Perhaps either all platform examples need the default increased, rather than increasing the problem task stacks as is done here.