Skip to content

Fix for protonvpn update-port.sh #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

BigRedBrent
Copy link
Contributor

@BigRedBrent BigRedBrent commented May 23, 2025

Disabled exiting on errors to allow the script to keep running even if commands fail, so that it can retry after 45 seconds on the next loop. (I've let the script run for several days, and it looks like this has resolved the issue of it stopping prematurely.)

Returned functionality to allow and deny ports in the firewall as necessary.

Modified the bind_trans function to be less complicated. Removed multiple attempts per loop, because it can retry after 45 seconds on the next loop.

Will now double check to make sure the port has actually changed on the next 45 second loop. This seems to catch incorrect port changes, or at the very least does not switch to a very short lived port change.

Breaking change

<placeholder>

Proposed change

<placeholder>

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New provider (thank you!)
  • Updated provider (thank you!)
  • New feature (which adds functionality to a provider script/repo usage)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: relates to #
  • Link to documentation updated (if done separately): https://...

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

Removed multiple attempts per loop, as they are unnecessary, since it can just retry the attempt on the next loop. This makes the code a bit less complicated.
Disabled exiting on errors to allow the script to keep running even if commands fail
Removed echo_debug function
@BigRedBrent BigRedBrent changed the title Update update-port.sh Update update-port.sh to disable exiting on errors May 26, 2025
Added functionality for firewall
@BigRedBrent BigRedBrent changed the title Update update-port.sh to disable exiting on errors Update update-port.sh to disable exiting on errors and added firewall functionality May 27, 2025
@BigRedBrent BigRedBrent changed the title Update update-port.sh to disable exiting on errors and added firewall functionality Update update-port.sh to disable exiting on errors and add firewall functionality May 27, 2025
@BigRedBrent BigRedBrent changed the title Update update-port.sh to disable exiting on errors and add firewall functionality Update update-port.sh May 30, 2025
@BigRedBrent BigRedBrent changed the title Update update-port.sh Fix for update-port.sh May 30, 2025
@BigRedBrent BigRedBrent changed the title Fix for update-port.sh Fix for protonvpn update-port.sh May 30, 2025
@BigRedBrent
Copy link
Contributor Author

I've been running this script for a while now, and it seems to work really well with the changes I've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant