Remove test-membership duplication
#1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR builder uses a local copy of an action which has [since been centralised](https://github.com/hazelcast/hazelcast-tpm/blob/main/membership/action.yaml). This was originally copied from the pattern in `hazelcast-nodejs-client` - but this has [since been migrated](https://github.com/hazelcast/hazelcast-nodejs-client/blob/master/.github/workflows/coverage_runner.yml#L16-L29). Updated to use centralise version - allowing a central place to make improvements.
ihsandemir
reviewed
Nov 12, 2024
nishaatr
approved these changes
Nov 12, 2024
ihsandemir
approved these changes
Nov 12, 2024
|
@ihsandemir it looks like the PR builders gone back to being flakey - but I don't think this change is related. Would you be able to force merge, please...? |
|
@JackPGreen We need to disable some tests. I submitted a PR for it. We need to disable these tests since we shutdown the test Aws instance permanently now due to costs. These tests need to change. Opened an issue for future reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR builder uses a local copy of an action which has since been centralised.
This was originally copied from the pattern in
hazelcast-nodejs-client- but this has since been migrated.Updated to use centralise version - allowing a central place to make improvements.