Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests [DI-337] #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve tests [DI-337] #241

wants to merge 1 commit into from
+11 −10

Conversation

JackPGreen
Copy link
Collaborator

@JackPGreen JackPGreen commented Nov 8, 2024 •
edited by jira bot
Loading

#237 highlighted a gap in our test process, investigation found further issues this PR addresses:

  • We test Debian packages on Ubuntu
    • A better target would be Debian, action updated to use debian:latest and install required tools
    • Note that this means the build now fails because the fix for Problem with upgrade Debian 12 #237 has yet to be merged - this is a good thing, as we've recreated the issue
  • Unnecessary Java installation
    • The Debian package specifies a JRE, we don't need to install our own
    • This didn't obscure the issue in Problem with upgrade Debian 12 #237, but if there was an incompatibility in Java versions, it might've been hidden
  • Test repo not reliably cleaned
    • The test undeploys the packages from the test repo, but only if it completes successfully - when it fails, it's not removed

Fixes: DI-337

Post-merge action:

  • copy to management centre

@JackPGreen JackPGreen mentioned this pull request Nov 8, 2024
Open
2 tasks
@JackPGreen JackPGreen self-assigned this Nov 8, 2024
@JackPGreen JackPGreen marked this pull request as ready for review November 8, 2024 11:34
nishaatr
nishaatr approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@nishaatr nishaatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs backport?

@JackPGreen
Copy link
Collaborator Author

Needs backport?

I don't think so.

@JackPGreen JackPGreen changed the title Improve tests Improve tests [DI-337] Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishaatr nishaatr nishaatr approved these changes

@ldziedziul ldziedziul Awaiting requested review from ldziedziul

Assignees

@JackPGreen JackPGreen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackPGreen @nishaatr