Fix DatetimeInput so it respects html5 wrapper configuration #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration for the html5 component.
|
Is there anything beyond updating this PR to the latest commit that is preventing this PR from getting merged? I'm interested in seeing this behavior 😄 In #1739 (comment), @rafaelfranca mentioned that he'd like to see the existing behavior matched, which might require additional changes to this ticket and the default configuration to disable these html5 fields by default. This PR could probably also be updated to say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #1739
I reorganized the tests a little bit. Tests which should generate html5 inputs were consolidated under
DateTimeInputWithHtml5Testand tests which shouldn't generate html5 inputs were consolidated underDateTimeInputWithoutHtml5Test.I also removed some unnecessary calls to
swap_wrappersince the default wrapper supports optional use of the html5 component.