Skip to content

Conversation

@heckj
Copy link
Owner

@heckj heckj commented Feb 19, 2025

  • make resources return optional instances to allow for missing resources on query
  • Update Verbosity to DetailLevel in command output

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected. Examples include renaming parameters in public API, removing public API, or adding a new parameter to public API without a default value.)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have run ./scripts/preflight.bash and it passed without errors.

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (5eb016b) to head (66cdbf8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Formic/Commands/SSHCommand.swift 0.00% 14 Missing ⚠️
Sources/Formic/ResourceTypes/Dpkg.swift 0.00% 12 Missing ⚠️
Sources/Formic/Resources/CollectionResource.swift 0.00% 2 Missing ⚠️
Sources/Formic/Engine/Engine.swift 66.66% 1 Missing ⚠️
Sources/Formic/RemoteHost.swift 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   69.14%   70.26%   +1.11%     
==========================================
  Files          26       26              
  Lines        1332     1288      -44     
==========================================
- Hits          921      905      -16     
+ Misses        411      383      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heckj heckj changed the title radically updating the API to resolve issues hit while developing with it Feb 19, 2025
@heckj heckj merged commit 33a871c into main Feb 19, 2025
3 checks passed
@heckj heckj deleted the cleanup-api branch February 19, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants