Skip to content

Conversation

@heckj
Copy link
Owner

@heckj heckj commented Feb 20, 2025

Description

  • removes Citadel and swift-crypto dependencies
  • shelves the SSHCommand (uses Citadel)

Motivation and Context

Seeing a build failure deep in things under linux, and it's not critical path, so removing to reduce the surface area to investigate.

Checklist

  • All new and existing tests passed.
  • I have run ./scripts/preflight.bash and it passed without errors.

@heckj heckj self-assigned this Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (33a871c) to head (91a6dae).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   70.57%   74.54%   +3.97%     
==========================================
  Files          26       25       -1     
  Lines        1288     1214      -74     
==========================================
- Hits          909      905       -4     
+ Misses        379      309      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heckj heckj merged commit 2e6deff into main Feb 20, 2025
3 checks passed
@heckj heckj deleted the shelve-citadel branch February 20, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants