Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 update the footer with better ordering and new icons #5404

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

El-Houssein-bedoui
Copy link
Contributor

Description: Create a kid-friendly footer that matches Hedy's platform vibe.

image

This PR related to discussion : #5381

How to test
In the main part, as you scroll down, you'll see the footer has changed.

Checklist

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

@Felienne
Copy link
Member

Thanks for the PR @El-Houssein-bedoui!

The test are failing since you have not added a translation:

image Can you add translations in at least English to the po files (https://github.com/hedyorg/hedy/pull/5404/files#diff-852046eb47f474139974edf5e69ed9758f9fde82e1432c49d772b89aef354b37)

@Felienne
Copy link
Member

Also, where do the images come from? I want to make sure we are not infringing on anyone's rights!

@El-Houssein-bedoui
Copy link
Contributor Author

The images are obtained from the website https://icons8.com/icons, where all PNG icons are provided for free download. However, there's uncertainty about whether we should attribute them.
If attribution is required, we can acknowledge the source or seek alternative icons available for free use or you could draw them as you mentioned in previous discussion.
( I am sorry , I am still learning about all these stuff and thank you for your time)

@El-Houssein-bedoui
Copy link
Contributor Author

El-Houssein-bedoui commented Apr 12, 2024

@Felienne i find these photo that you can use without any attribution or credit "form https://uxwing.com" but the previous icons are surely better then these. So as I mentioned in the previous comment what do you think we should do ? Thank you.
image

@Felienne
Copy link
Member

@Felienne i find these photo that you can use without any attribution or credit "form https://uxwing.com" but the previous icons are surely better then these. So as I mentioned in the previous comment what do you think we should do ? Thank you. image

Yeah I like the first ones better too but we have to be sure about what we can use. I think the best course of action is that I draw icons, then they'd be in our style and we can surely use then but I will not have tine to do so very soon, sorry!

@El-Houssein-bedoui
Copy link
Contributor Author

@Felienne Hello ,I've been in touch with Icons8. I've purchased their subscription for $14 (no need to worry, I'll be utilizing them in future projects as well ...), granting me the right to use them without any attribution. Additionally, I've made some enhancements to the footer.
So, I believe we're all set for now. Thank you.
pic
image
image
image

@El-Houssein-bedoui
Copy link
Contributor Author

@Felienne Hey , I just want to know is there any other problem in my request so I could fix it . Thank you .

@Felienne
Copy link
Member

@Felienne Hey , I just want to know is there any other problem in my request so I could fix it . Thank you .

Hi @El-Houssein-bedoui! No there is nothing wrong, the action is now with me, I will draw the icons in our style. But I am busy the next two weeks with another important deadline so I will not be able to do it soon. Thanks for understanding and thanks for being patient!

@El-Houssein-bedoui
Copy link
Contributor Author

@Felienne as I mentioned in the previous discussion , now I have the right to use the icons and it is like hedy's style so there is no need to draw them . But if you want to for sure . Thank you for your reply.

@hasan-sh hasan-sh marked this pull request as draft April 16, 2024 15:47
@hasan-sh
Copy link
Collaborator

Hello @El-Houssein-bedoui thanks for the effort, will keep in touch :)

@El-Houssein-bedoui El-Houssein-bedoui marked this pull request as ready for review April 18, 2024 00:13
@Felienne Felienne changed the title Enhancing Footer for better interface and User Experience💻update the footer 💻 update the footer with better ordering and new icons Apr 18, 2024
@Felienne Felienne marked this pull request as draft April 18, 2024 09:02
@El-Houssein-bedoui El-Houssein-bedoui marked this pull request as ready for review April 21, 2024 12:06
@Felienne Felienne marked this pull request as draft April 24, 2024 13:09
@Felienne
Copy link
Member

Until I make the icons, let's keep this on draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants