Skip to content

Conversation

bobidle
Copy link
Contributor

@bobidle bobidle commented Mar 29, 2025

Fixes #4961 #6225

How to test

Follow these steps to verify this PR works as intended:

  • switch a music adventure to German
  • play note H as a replacement of note B

Checklist
Done? Check if you have it all in place using this list: (mark with x if done)

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

@AnneliesVlaar
Copy link
Collaborator

Hi @bobidle Thanks for working on the music. It's been a while since you've worked on this pull request. I see it is still in draft, are you still working on it? If it is ready, please mark it as ready for review, then we will look at it! The same holds for '💻 Add music note H as an alias of music note B #6226

@bobidle
Copy link
Contributor Author

bobidle commented May 16, 2025

Thank you @AnneliesVlaar, at the moment the code does not work for all languages, but it should add a demonstration how it could work. I still want to work on and finish it. Also i want to make the notes available as Do Re Mi Fa Sol La Ti where the naming could also be different by country.

@AnneliesVlaar
Copy link
Collaborator

That's very interesting @bobidle, thank you for diving into it! We're looking forward to the result and will wait for when it's ready to review.

@bobidle bobidle force-pushed the make_music_notes_translatable branch from 9a855d3 to 24a4470 Compare May 22, 2025 17:50
@rix0rrr rix0rrr force-pushed the main branch 6 times, most recently from 674bb9f to 207fc8b Compare July 14, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress
Status: Review for relevance

Development

Successfully merging this pull request may close these issues.

🎶 Localize music notes

2 participants