fix php8 warning

heimrichhannot · Dec 11, 2024 · 734ba11 · 734ba11
1 parent 7100a46
commit 734ba11
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [1.4.1] - 2024-12-11
+- Fixed: php8 warning
+
 ## [1.4.0] - 2024-03-14
 - Changed: require contao 4.13
 - Changed: allow php 8

diff --git a/models/NewsPlusModel.php b/models/NewsPlusModel.php
@@ -76,8 +76,7 @@ protected static function filterByCategories($arrColumns)
         $t = static::$strTable;
 
         // Use the default filter
-        if (is_array($GLOBALS['NEWS_FILTER_DEFAULT']) && !empty($GLOBALS['NEWS_FILTER_DEFAULT']))
-        {
+        if (isset($GLOBALS['NEWS_FILTER_DEFAULT']) && is_array($GLOBALS['NEWS_FILTER_DEFAULT']) && !empty($GLOBALS['NEWS_FILTER_DEFAULT'])) {
             $arrCategories = static::getCategoriesCache();
 
             if (!empty($arrCategories))
@@ -109,8 +108,7 @@ protected static function filterByCategories($arrColumns)
         }
 
         // Try to find by category
-        if ($GLOBALS['NEWS_FILTER_CATEGORIES'] && \Input::get('category'))
-        {
+        if (isset($GLOBALS['NEWS_FILTER_CATEGORIES']) && $GLOBALS['NEWS_FILTER_CATEGORIES'] && \Input::get('category')) {
             $objCategory = NewsCategoryModel::findPublishedByIdOrAlias(\Input::get('category'));