Skip to content

Conversation

@arjav-desai
Copy link
Member

@arjav-desai arjav-desai commented Jul 23, 2025

Showcases support/usage of helidon-io/helidon#10146 and helidon-io/helidon#10057

@arjav-desai arjav-desai self-assigned this Jul 23, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 23, 2025
@spericas
Copy link
Member

Just curious, this looks very similar to the other example that we have except for the use of Coherence, right? Would it make sense to combine the examples with settings to use or not use Coherence instead?

@arjav-desai arjav-desai changed the title Example for Coherence Embedding Store Support Example for Coherence LC4J Provider Usage Jul 28, 2025
@arjav-desai
Copy link
Member Author

Just curious, this looks very similar to the other example that we have except for the use of Coherence, right? Would it make sense to combine the examples with settings to use or not use Coherence instead?

There are differences in the way coherence is started in main class and then used on chat service for memory as well as configuration. Keeping it in existing sample with if/else or config based would have make it more confusing than helpful.

@arjav-desai arjav-desai marked this pull request as ready for review August 26, 2025 19:01
@arjav-desai arjav-desai moved this to Sprint Scope in Backlog Aug 26, 2025
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, and maybe some other changes.

@arjav-desai arjav-desai requested a review from tjquinno August 27, 2025 15:53
@arjav-desai arjav-desai merged commit aea1d11 into helidon-io:dev-4.x Aug 28, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Sprint Scope to Closed in Backlog Aug 28, 2025
@arjav-desai arjav-desai changed the title Example for Coherence LC4J Provider Usage Example for Coherence LC4J Provider and Metrics Usage Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants