Skip to content

Conversation

@tjquinno
Copy link
Member

@tjquinno tjquinno commented Sep 17, 2025

Resolves helidon-io/helidon#10608

This PR adds an example illustrating how to use telemetry configuration via SE config.

Note that the PR depends on Helidon PR helidon-io/helidon#10684 a new, not-yet-merged merged as of 22 September 2025 component in core Helidon (helidon-telemetry-testing-tracing).

@tjquinno tjquinno requested a review from barchetta September 17, 2025 21:12
@tjquinno tjquinno self-assigned this Sep 17, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 17, 2025
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to remove .dockerignore, .gitignore, app.yaml, Dockerfile*

@tjquinno tjquinno force-pushed the 4.x-telemetry-examples branch from 7087ba4 to 2cd159e Compare September 29, 2025 16:30
<groupId>io.helidon.examples.telemetry</groupId>
<artifactId>helidon-examples-telemetry-se-config</artifactId>
<version>1.0-SNAPSHOT</version>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <name>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// initialize config from default configuration
Config config = Services.get(Config.class);

// Fetch the OpenTelemetry instance from the service registry to make sure it is initialized
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Removed.

@romain-grecourt
Copy link
Contributor

There are very few directories named "*-se".
In the current structure, the default is SE and MP examples are nested under microprofile.

@tjquinno
Copy link
Member Author

tjquinno commented Sep 29, 2025

There are very few directories named "*-se". In the current structure, the default is SE and MP examples are nested under microprofile.

I'll rename it. Renamed.

barchetta
barchetta previously approved these changes Sep 29, 2025
@barchetta barchetta merged commit 36b81da into dev-4.x Sep 29, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants