-
Notifications
You must be signed in to change notification settings - Fork 10
Add OCI basic setup that will be used for the OCI Guide #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCI basic setup that will be used for the OCI Guide #21
Conversation
rhomast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small changes for grammar.
Appreciate the comments and updated accordingly. |
edbratt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The outline is great and overall, this is exactly what we need. These are some nit-picky comments. You may decide if you want to accept any of these or just resolve them.
…again with newer values.
rhomast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nitpicks but overall, looks good!
| 4. Install the Helidon CLI generic distribution. | ||
| 1. Download and extract the Helidon CLI generic distribution | ||
| ```shell | ||
| curl -L -O https://github.com/helidon-io/helidon-build-tools/releases/download/3.0.6/helidon-cli.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommended approach to download CLI is curl -L -O https://helidon.io/cli/latest/linux/helidon based on https://helidon.io/docs/v4/about/cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, that will only work for Linux x64 platform. Cloud Shell no runs on Linux ARM by default and we don't have a distro for it yet, so the generic java distro is the only option for now.
| 2. oci.monitoring.namespace - This can be any string but for this demo, this will be set to `helidon_application`. | ||
| 3. oci.logging.id - Application log id that was provisioned by the terraform scripts. | ||
|
|
||
| **Note:** Make sure to validate that `application.yaml` and `microprofile-config.properties` were updated by checking that the mentioned config parameters were properly populated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2cents: just keep properties file and not yaml.
No description provided.