Skip to content

Conversation

@klustria
Copy link
Member

No description provided.

@klustria klustria self-assigned this Apr 30, 2025
@klustria klustria changed the title Add exercise for a Basic OCI setup that will be used for the OCI Guide Add OCI basic setup that will be used for the OCI Guide Apr 30, 2025
Copy link

@rhomast rhomast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small changes for grammar.

@klustria
Copy link
Member Author

Mostly small changes for grammar.

Appreciate the comments and updated accordingly.

@klustria klustria requested a review from rhomast April 30, 2025 18:17
rhomast
rhomast previously approved these changes Apr 30, 2025
Copy link
Member

@edbratt edbratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outline is great and overall, this is exactly what we need. These are some nit-picky comments. You may decide if you want to accept any of these or just resolve them.

@klustria klustria requested review from edbratt and rhomast May 2, 2025 07:15
Copy link

@rhomast rhomast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nitpicks but overall, looks good!

4. Install the Helidon CLI generic distribution.
1. Download and extract the Helidon CLI generic distribution
```shell
curl -L -O https://github.com/helidon-io/helidon-build-tools/releases/download/3.0.6/helidon-cli.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommended approach to download CLI is curl -L -O https://helidon.io/cli/latest/linux/helidon based on https://helidon.io/docs/v4/about/cli

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, that will only work for Linux x64 platform. Cloud Shell no runs on Linux ARM by default and we don't have a distro for it yet, so the generic java distro is the only option for now.

@klustria klustria requested review from arjav-desai and rhomast May 2, 2025 15:43
@klustria klustria merged commit 349e308 into helidon-io:main May 2, 2025
7 checks passed
2. oci.monitoring.namespace - This can be any string but for this demo, this will be set to `helidon_application`.
3. oci.logging.id - Application log id that was provisioned by the terraform scripts.

**Note:** Make sure to validate that `application.yaml` and `microprofile-config.properties` were updated by checking that the mentioned config parameters were properly populated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2cents: just keep properties file and not yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants