Skip to content

Support for McpRequest in declarative + Resource templates cannot be read #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2025
Merged

Support for McpRequest in declarative + Resource templates cannot be read #14

merged 3 commits into from
Aug 25, 2025

Conversation

@tvallin
Copy link
Member

@tvallin tvallin commented Aug 25, 2025

This PR add the following:

  • Support for McpRequest in MCP components method for declarative.

This is now working:

@Mcp.Tool(TOOL_DESCRIPTION)
List<McpToolContent> myTool(McpRequest request) {
    return List.of(McpToolContents.textContent("result"));
}
  • Fix a bug where resource template can be read.
  • Add test for McpServer configuration (No changes to implementation nor API)

@tvallin tvallin self-assigned this Aug 25, 2025
@tvallin tvallin added the bug Something isn't working label Aug 25, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 25, 2025
spericas
spericas approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomas-langer
tomas-langer approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvallin tvallin merged commit fd24c73 into helidon-io:main Aug 25, 2025
11 checks passed
@tvallin tvallin deleted the mcp-request-declarative branch August 25, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spericas spericas spericas approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@tvallin tvallin

Labels

bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvallin @spericas @tomas-langer