Skip to content

Replace Java util logger by System.Logger in all modules #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2025
Merged

Replace Java util logger by System.Logger in all modules #83

merged 2 commits into from
Oct 21, 2025

Conversation

@tvallin
Copy link
Member

@tvallin tvallin commented Oct 21, 2025

Fixes #72

This PR brings a few changes:

  • Update Java logger to System logger
  • Add Error code to McpInternalException
  • Remove the helidon-http-media-jsonp dependency and use instead the necessary ones.

@tvallin tvallin requested a review from spericas October 21, 2025 13:47
@tvallin tvallin self-assigned this Oct 21, 2025
@tvallin tvallin added the bug Something isn't working label Oct 21, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 21, 2025
spericas
spericas previously approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@spericas spericas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but System.Logger.Level.DEBUG is a bit long for constant, an import would help.

@tvallin tvallin merged commit 2042a61 into helidon-io:main Oct 21, 2025
11 checks passed
@tvallin tvallin deleted the system-logger branch October 21, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spericas spericas spericas approved these changes

Assignees

@tvallin tvallin

Labels

bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace Java util logger by System.Logger in all modules

2 participants

@tvallin @spericas