-
Notifications
You must be signed in to change notification settings - Fork 579
Adds support for JSON-RPC client and server APIs #10244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f2cc74
to
f235b10
Compare
tomas-langer
requested changes
Jun 17, 2025
jsonrpc/core/src/main/java/io/helidon/jsonrpc/core/JsonRpcErrorImpl.java
Outdated
Show resolved
Hide resolved
jsonrpc/core/src/main/java/io/helidon/jsonrpc/core/JsonRpcErrorImpl.java
Outdated
Show resolved
Hide resolved
jsonrpc/core/src/main/java/io/helidon/jsonrpc/core/JsonRpcParams.java
Outdated
Show resolved
Hide resolved
jsonrpc/core/src/main/java/io/helidon/jsonrpc/core/JsonRpcParamsImpl.java
Outdated
Show resolved
Hide resolved
webserver/jsonrpc/src/main/java/io/helidon/webserver/jsonrpc/JsonRpcResponse.java
Show resolved
Hide resolved
webserver/jsonrpc/src/main/java/io/helidon/webserver/jsonrpc/JsonRpcResponse.java
Show resolved
Hide resolved
webserver/jsonrpc/src/main/java/io/helidon/webserver/jsonrpc/JsonRpcRulesImpl.java
Outdated
Show resolved
Hide resolved
tvallin
reviewed
Jun 20, 2025
webserver/jsonrpc/src/main/java/io/helidon/webserver/jsonrpc/JsonRpcRouting.java
Show resolved
Hide resolved
84313f1
to
352f7d9
Compare
jsonrpc/core/src/main/java/io/helidon/jsonrpc/core/JsonUtil.java
Outdated
Show resolved
Hide resolved
5742d95
to
394c06e
Compare
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
…s returning 200 with appropriate JSON-RPC error.
…equests based on spec examples and adds more tests.
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
…for injecting JsonRpcClient in tests. Relocates tests.
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
… other issues found during review.
…ew other issues in the API.
…() instead of just method().
…Handler>. If the optional is empty, error is ignored; otherwise, the error returned is sent back to the client.
…JSON conversions. Removes dep with features API.
…pRouting methods.
e36dbe8
to
b062dbf
Compare
b30df91
to
8bf6f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a PR agains your branch.
…figuration (#6) Fix of Helidon Feature, where preview features were ignored during printout.
tomas-langer
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
webclient
webserver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for JSON-RPC client and server APIs. See issue #10286.