4.x: Remove unused code from io.helidon.metrics.providers.micrometer.MMeterRegistry #10283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Captain1653
force-pushed
the
mmeter-registry-unused-code
branch
from
7e404cd to
13c1da4
Compare
|
Let's not proceed with this PR right away. I'm concerned particularly that |
|
Sure, no problem. I or you can convert this PR to draft if it's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've found unused code in
MMeterRegistry:createensurePrometheusRegistryIsPresentClockWrapperIt can be safely removed without breaking compatibility.