Skip to content

4.2.4: Use BOMs to manage versions of junit and langchain4j #10363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Jul 9, 2025

Use BOMs to manage versions of junit and langchain4j

This does not upgrade langchain4j

This upgrades junit to 5.11.3 to align with the version of junit-platform-testkit

@barchetta barchetta requested a review from danielkec July 9, 2025 23:40
@barchetta barchetta self-assigned this Jul 9, 2025
@barchetta barchetta added build dependencies Pull requests that update a dependency file 4.x Version 4.x labels Jul 9, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 9, 2025
@barchetta barchetta added this to the 4.2.4 milestone Jul 9, 2025
@barchetta barchetta mentioned this pull request Jul 9, 2025
20 tasks
ljnelson
ljnelson previously approved these changes Jul 9, 2025
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FWIW

danielkec
danielkec previously approved these changes Jul 10, 2025
@barchetta barchetta dismissed stale reviews from danielkec and ljnelson via 880dee9 July 10, 2025 18:10
@barchetta
Copy link
Member Author

The issues with the spring eureka integration tests is caused by the broken langchain4j bom's that are managing versions of things like junit and logback. Langchain4j is fixing their bom's but for 0.36.2 they are broken.

So I'm going to bail on this PR - and we'll address this in 4.3.0 when we pick up later versions of langchain4j with fixed boms.

@barchetta barchetta closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x build dependencies Pull requests that update a dependency file OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants