Adds support for multi-line SSE event #10406
Open
+92
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…'\n' on the client side and reported as a single event.
tvallin
reviewed
Jul 22, 2025
| if (!(data instanceof String)) { | ||
| throw new IllegalArgumentException("Cannot concatenate non-string event data"); | ||
| } | ||
| this.data += "\n" + data; // concatenate strings |
There was a problem hiding this comment.
/n is by the spec and is not a platform specific new line right ?
| static void sseString2(ServerRequest req, ServerResponse res) { | ||
| try (SseSink sseSink = res.sink(SseSink.TYPE)) { | ||
| sseSink.emit(SseEvent.builder() | ||
| .data("first line") |
There was a problem hiding this comment.
Do we want to add new method to create a multi line data event like this ?
Builder data(List<String> data);or
Builder data(String... data);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for multi-line SSE events. These are concatenated using '\n' on the client side and reported as a single event. See issue #10380.
Documentation
None