Log warnings (if not configured to suppress) upon multiple instantiations of MMeterRegistry
#10859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
… but very confusing corruption of the static data we use to display the multiple instantiations
tomas-langer
requested changes
Nov 27, 2025
|
|
||
| // For testing. | ||
| static void clearMultipleInstantiationInfo() { | ||
| hasLoggedFirstMultiInstantiationWarning = false; |
Member
There was a problem hiding this comment.
Field are not volatile and not guarded by a lock - this may not work as expected.
|
|
||
| @BeforeAll | ||
| static void beforeAll() { | ||
| baos = new ByteArrayOutputStream(); |
Member
There was a problem hiding this comment.
Stealing the system error output will also disable output of Junit framework itself.
I think we are using a custom in-memory logging appender in some other test, which is a better approach to check this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #10858
Release Note
Helidon now logs warnings if more than one meter registry is instantiated (unless suppressed by setting
metrics.warn-on-multiple-registriestofalse).PR background
The Helidon implementation of the
MeterRegistryinterface for the Micrometer implementation (MMeterRegistry) now:See the issue for a summary of the most frequent case where this has been a problem.
The PR includes tests which divert
System.errto a local stream so it can be inspected to make sure the expected log messages appear and unexpected ones do not appear.Documentation
No doc update.