Skip to content

Conversation

@danielkec
Copy link
Contributor

Fixes #5227

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 27, 2025
@danielkec danielkec requested a review from Copilot November 27, 2025 14:29
Copilot finished reviewing on behalf of danielkec November 27, 2025 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds config-metadata support to three messaging connectors (JMS, AQ, and Kafka) by introducing @Configured and @ConfiguredOption annotations to enable automatic configuration metadata generation. The changes include adding the necessary dependencies, configuring annotation processors, updating module descriptors, annotating config builder classes, and updating documentation to reference the generated config documentation.

  • Added config metadata annotations to builder classes for automated configuration documentation
  • Configured Maven annotation processors for metadata generation during compilation
  • Updated documentation to reference generated configuration metadata instead of manual tables
  • Cleaned up unused imports (io.helidon.common.features.api.Aot) from module-info files

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
messaging/connectors/kafka/src/main/java/module-info.java Added static requirement for io.helidon.config.metadata module
messaging/connectors/kafka/src/main/java/io/helidon/messaging/connectors/kafka/KafkaConfigBuilder.java Added @configured and @ConfiguredOption annotations to all builder methods; updated copyright year
messaging/connectors/kafka/pom.xml Added helidon-config-metadata dependency and configured annotation processors for metadata codegen
messaging/connectors/jms/src/main/java/module-info.java Added static requirement for io.helidon.config.metadata module; removed unused Aot import
messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java Added @configured and @ConfiguredOption annotations to all builder methods; updated copyright year
messaging/connectors/jms/pom.xml Added helidon-config-metadata dependency and configured annotation processors for metadata codegen
messaging/connectors/aq/src/main/java/module-info.java Added static requirement for io.helidon.config.metadata module; removed unused Aot import
messaging/connectors/aq/src/main/java/io/helidon/messaging/connectors/aq/AqConfigBuilder.java Added @configured and @ConfiguredOption annotations to all methods including new methods (clientId, durable, subscriberName, nonLocal); cleaned up javadoc; added JmsConnector import; updated copyright year
messaging/connectors/aq/pom.xml Added helidon-config-metadata dependency and configured annotation processors for metadata codegen
docs/src/main/asciidoc/mp/reactivemessaging/kafka.adoc Updated structure and replaced manual config documentation with reference to generated metadata
docs/src/main/asciidoc/mp/reactivemessaging/jms.adoc Replaced manual attributes table with reference to generated metadata documentation
docs/src/main/asciidoc/mp/reactivemessaging/aq.adoc Replaced manual attributes table with reference to generated metadata documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec requested a review from Copilot November 27, 2025 16:26
Copilot finished reviewing on behalf of danielkec November 27, 2025 16:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielkec danielkec requested a review from barchetta November 27, 2025 17:11
@danielkec danielkec self-assigned this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: KafkaConfigBuilder missing config-metadata

1 participant