-
Notifications
You must be signed in to change notification settings - Fork 585
Add config-metadata support to JMS, AQ & Kafka connectors #5227 #10863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add config-metadata support to JMS, AQ & Kafka connectors #5227 #10863
Conversation
…5227 Signed-off-by: Daniel Kec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds config-metadata support to three messaging connectors (JMS, AQ, and Kafka) by introducing @Configured and @ConfiguredOption annotations to enable automatic configuration metadata generation. The changes include adding the necessary dependencies, configuring annotation processors, updating module descriptors, annotating config builder classes, and updating documentation to reference the generated config documentation.
- Added config metadata annotations to builder classes for automated configuration documentation
- Configured Maven annotation processors for metadata generation during compilation
- Updated documentation to reference generated configuration metadata instead of manual tables
- Cleaned up unused imports (io.helidon.common.features.api.Aot) from module-info files
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| messaging/connectors/kafka/src/main/java/module-info.java | Added static requirement for io.helidon.config.metadata module |
| messaging/connectors/kafka/src/main/java/io/helidon/messaging/connectors/kafka/KafkaConfigBuilder.java | Added @configured and @ConfiguredOption annotations to all builder methods; updated copyright year |
| messaging/connectors/kafka/pom.xml | Added helidon-config-metadata dependency and configured annotation processors for metadata codegen |
| messaging/connectors/jms/src/main/java/module-info.java | Added static requirement for io.helidon.config.metadata module; removed unused Aot import |
| messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java | Added @configured and @ConfiguredOption annotations to all builder methods; updated copyright year |
| messaging/connectors/jms/pom.xml | Added helidon-config-metadata dependency and configured annotation processors for metadata codegen |
| messaging/connectors/aq/src/main/java/module-info.java | Added static requirement for io.helidon.config.metadata module; removed unused Aot import |
| messaging/connectors/aq/src/main/java/io/helidon/messaging/connectors/aq/AqConfigBuilder.java | Added @configured and @ConfiguredOption annotations to all methods including new methods (clientId, durable, subscriberName, nonLocal); cleaned up javadoc; added JmsConnector import; updated copyright year |
| messaging/connectors/aq/pom.xml | Added helidon-config-metadata dependency and configured annotation processors for metadata codegen |
| docs/src/main/asciidoc/mp/reactivemessaging/kafka.adoc | Updated structure and replaced manual config documentation with reference to generated metadata |
| docs/src/main/asciidoc/mp/reactivemessaging/jms.adoc | Replaced manual attributes table with reference to generated metadata documentation |
| docs/src/main/asciidoc/mp/reactivemessaging/aq.adoc | Replaced manual attributes table with reference to generated metadata documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...aging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java
Outdated
Show resolved
Hide resolved
...aging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java
Outdated
Show resolved
Hide resolved
...aging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java
Outdated
Show resolved
Hide resolved
messaging/connectors/aq/src/main/java/io/helidon/messaging/connectors/aq/AqConfigBuilder.java
Outdated
Show resolved
Hide resolved
messaging/connectors/aq/src/main/java/io/helidon/messaging/connectors/aq/AqConfigBuilder.java
Outdated
Show resolved
Hide resolved
messaging/connectors/aq/src/main/java/io/helidon/messaging/connectors/aq/AqConfigBuilder.java
Outdated
Show resolved
Hide resolved
...aging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java
Outdated
Show resolved
Hide resolved
...aging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConfigBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #5227