4.x: Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml tests #8173

jbescos · 2023-12-20T12:37:03Z

Description

We were waiting for microprofile-config 3.1 to enable one test. This version made other issues that are fixed in this PR too.

There were 2 types of issues:

In one case we were returning an empty optional of the ConfigValue. It needs to have some properties, like ordinal and name.
We were iterating the sources for profile and then for non-profile. It has to be iterated in the way that each source is iterated with and without profile because of the ordinal value.

Documentation

N/A

…tests helidon-io#8173 Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos · 2023-12-21T07:52:38Z

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java

            } catch (NoSuchElementException e) {
-                // Property expression does not resolve
-                return Optional.empty();
+                return Optional.of(new ConfigValueImpl(propName, null, rawValue, name, ordinal));


This is the point 1 I was referring before.

tomas-langer · 2024-01-18T14:20:46Z

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java

    }

-    private Optional<ConfigValue> findConfigValue(String propertyName) {
+    private Optional<ConfigValue> findConfigValue(String propertyName, Optional<String> profiledPropertyName) {


we do not use optional parameters. Also it does not make sense in this case, as you wrap it just to unwrap it later. Please use null here, as it is a private method (null is not allowed in public API only).

tomas-langer · 2024-01-18T14:24:45Z

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java

+            String rawValue = value;
+            String name = source.getName();
+            int ordinal = source.getOrdinal();
+            final String propName = selectedProperty;


This name is not descriptive. Use selectedPropertyFinal or something similar, with a comment "required final variable, as it is used in lambdas"

tomas-langer · 2024-01-18T14:28:31Z

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java

    @SuppressWarnings("unchecked")
    @Override
    public <T> Optional<T> getOptionalValue(String propertyName, Class<T> propertyType) {
+        String profiledPropertyName = null;


This statement does not make sense here - the next if is checking for profile being null. So just move the content of the if statement after the if checking if profile is null and remove the check.

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java

jbescos · 2024-02-21T10:50:02Z

@tomas-langer kindly reminder to review this.

jbescos · 2024-06-10T07:50:00Z

After merging main I found out this already sort out the problems:
#8757

jbescos · 2024-12-16T10:43:34Z

@tomas-langer please review/approve this so I can run TCKs with Java 24 with this test too.

tomas-langer · 2025-02-20T13:51:35Z

microprofile/tests/server/pom.xml

            <scope>test</scope>
        </dependency>
    </dependencies>
+    <build>


This change does not seem to be required for the described problem. This is tests/server, not TCK

I don't remember the context of this. Probably it was necessary at some point when this PR had other changes. It is removed now.

tomas-langer · 2025-07-10T09:17:28Z

Please rebase on main, do not merge
We must use Rebase and merge as the way to merge PRs

tomas-langer

PR should be probably reworked on main branch and just do the one change that is left.
We must rebase, not merge with main

…tests helidon-io#8173 Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos · 2025-07-10T13:59:20Z

PR should be probably reworked on main branch and just do the one change that is left. We must rebase, not merge with main

I like merges because it is less work, but I have re-based it following your indications. Let me know if you prefer that I make a new PR with the only single file that needs to be changed and we close this one.

jbescos · 2025-07-14T09:36:09Z

Now TCK is failing. Probably something in code has changed since I created this PR. I will need to check it again.

jbescos · 2025-07-16T08:58:15Z

It is passing in my computer

jbescos · 2025-07-16T09:53:09Z

Issue here is the next. It looks there are two #computeIfAbsent within the same stack:

Caused by: java.lang.IllegalStateException: Recursive update
	at java.base/java.util.concurrent.ConcurrentHashMap.transfer(ConcurrentHashMap.java:2552)
	at java.base/java.util.concurrent.ConcurrentHashMap.addCount(ConcurrentHashMap.java:2354)
	at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1776)
	at io.helidon.common.types.TypeStash.stash(TypeStash.java:45)
	at io.helidon.common.types.TypeNameSupport.create(TypeNameSupport.java:244)
	at io.helidon.common.types.TypeName.create(TypeName.java:80)
	at io.helidon.common.types.TypeNameSupport.updateFromClass(TypeNameSupport.java:483)
	at io.helidon.common.types.TypeNameSupport.type(TypeNameSupport.java:177)
	at io.helidon.common.types.TypeName$BuilderBase.type(TypeName.java:257)
	at io.helidon.common.types.TypeNameSupport.doCreate(TypeNameSupport.java:251)
	at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
	at io.helidon.common.types.TypeStash.stash(TypeStash.java:45)
	at io.helidon.common.types.TypeNameSupport.create(TypeNameSupport.java:244)
	at io.helidon.common.types.TypeName.create(TypeName.java:80)
	at io.helidon.common.types.ResolvedType.create(ResolvedType.java:35)
	at io.helidon.microprofile.cdi.ServiceRegistryExtension.addCdiBean(ServiceRegistryExtension.java:379)
	at io.helidon.microprofile.cdi.ServiceRegistryExtension.doProcessBean(ServiceRegistryExtension.java:[457](https://github.com/helidon-io/helidon/actions/runs/16315697340/job/46081462429?pr=8173#step:3:469))
	at io.helidon.microprofile.cdi.ServiceRegistryExtension.processSyntheticBean(ServiceRegistryExtension.java:148)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.jboss.weld.injection.StaticMethodInjectionPoint.invoke(StaticMethodInjectionPoint.java:95)
	at org.jboss.weld.injection.MethodInvocationStrategy$SpecialParamPlusBeanManagerStrategy.invoke(MethodInvocationStrategy.java:187)
	at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:330)
	at org.jboss.weld.event.ExtensionObserverMethodImpl.sendEvent(ExtensionObserverMethodImpl.java:126)
	at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:308)
	at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:286)
	at jakarta.enterprise.inject.spi.ObserverMethod.notify(ObserverMethod.java:142)
	at org.jboss.weld.util.Observers.notify(Observers.java:166)
	at org.jboss.weld.event.ObserverNotifier.notifySyncObservers(ObserverNotifier.java:285)
	at org.jboss.weld.event.ObserverNotifier.notify(ObserverNotifier.java:273)
	at org.jboss.weld.event.ObserverNotifier.fireEvent(ObserverNotifier.java:177)
	at org.jboss.weld.event.ObserverNotifier.fireEvent(ObserverNotifier.java:171)
	at org.jboss.weld.bootstrap.events.AbstractContainerEvent.fire(AbstractContainerEvent.java:53)
	at org.jboss.weld.bootstrap.events.AbstractDefinitionContainerEvent.fire(AbstractDefinitionContainerEvent.java:45)
	at org.jboss.weld.bootstrap.events.ProcessSynthethicBeanImpl.fire(ProcessSynthethicBeanImpl.java:40)
	at org.jboss.weld.bootstrap.events.ProcessSynthethicBeanImpl.fire(ProcessSynthethicBeanImpl.java:34)
	at org.jboss.weld.bootstrap.events.ContainerLifecycleEvents.fireProcessBean(ContainerLifecycleEvents.java:255)
	at org.jboss.weld.bootstrap.events.AfterBeanDiscoveryImpl.processBeanRegistration(AfterBeanDiscoveryImpl.java:238)
	at org.jboss.weld.bootstrap.events.AfterBeanDiscoveryImpl.finish(AfterBeanDiscoveryImpl.java:192)
	at org.jboss.weld.bootstrap.events.AfterBeanDiscoveryImpl.fire(AfterBeanDiscoveryImpl.java:76)
	at org.jboss.weld.bootstrap.WeldStartup.deployBeans(WeldStartup.java:[458](https://github.com/helidon-io/helidon/actions/runs/16315697340/job/46081462429?pr=8173#step:3:470))
	at org.jboss.weld.bootstrap.WeldBootstrap.deployBeans(WeldBootstrap.java:87)
	at io.helidon.microprofile.cdi.HelidonContainerImpl.init(HelidonContainerImpl.java:218)

…tests helidon-io#8173 Signed-off-by: Jorge Bescos Gascon <[email protected]>

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos · 2025-11-28T09:46:49Z

@tomas-langer it is passing now

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 20, 2023

jbescos force-pushed the issue6105 branch 2 times, most recently from 146f4fb to 82c58c7 Compare December 20, 2023 13:40

jbescos requested a review from tomas-langer December 20, 2023 15:03

jbescos force-pushed the issue6105 branch from af77287 to 1b27d61 Compare December 21, 2023 07:48

jbescos added a commit to jbescos/helidon that referenced this pull request Dec 21, 2023

4.x: Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml …

1b27d61

…tests helidon-io#8173 Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos commented Dec 21, 2023

View reviewed changes

tomas-langer requested changes Jan 18, 2024

View reviewed changes

jbescos force-pushed the issue6105 branch 5 times, most recently from 6dc63dd to 325790c Compare January 24, 2024 10:57

jbescos self-assigned this May 3, 2024

jbescos requested a review from tomas-langer October 1, 2024 10:55

tomas-langer reviewed Feb 20, 2025

View reviewed changes

tomas-langer approved these changes Jul 10, 2025

View reviewed changes

tomas-langer requested changes Jul 10, 2025

View reviewed changes

jbescos added a commit to jbescos/helidon that referenced this pull request Jul 10, 2025

4.x: Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml …

9702fa9

…tests helidon-io#8173 Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue6105 branch from e1ea828 to 221319c Compare July 10, 2025 13:58

jbescos force-pushed the issue6105 branch from 221319c to 95018c1 Compare July 10, 2025 14:22

jbescos force-pushed the issue6105 branch from 95018c1 to ecbfd3a Compare July 16, 2025 08:57

jbescos force-pushed the issue6105 branch from ecbfd3a to 6984941 Compare July 16, 2025 09:26

jbescos force-pushed the issue6105 branch from 6984941 to 43a331a Compare August 1, 2025 07:37

jbescos added 3 commits November 28, 2025 10:03

4.x: Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml …

47fb50a

…tests helidon-io#8173 Signed-off-by: Jorge Bescos Gascon <[email protected]>

Review comments 1

e619c9a

Signed-off-by: Jorge Bescos Gascon <[email protected]>

Review comments and copyright

b1b2490

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue6105 branch from 43a331a to b1b2490 Compare November 28, 2025 09:04

4.x: Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml tests #8173

Are you sure you want to change the base?

4.x: Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml tests #8173

Uh oh!

Conversation

jbescos commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Documentation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbescos commented Feb 21, 2024

Uh oh!

jbescos commented Jun 10, 2024

Uh oh!

jbescos commented Dec 16, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomas-langer commented Jul 10, 2025

Uh oh!

tomas-langer left a comment

Choose a reason for hiding this comment

Uh oh!

jbescos commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbescos commented Jul 14, 2025

Uh oh!

jbescos commented Jul 16, 2025

Uh oh!

jbescos commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbescos commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jbescos commented Dec 20, 2023 •

edited

Loading

jbescos commented Jul 10, 2025 •

edited

Loading

jbescos commented Jul 16, 2025 •

edited

Loading