Issue #7102 - WebClient should have a mode that is resilient to bad media/content types #9040
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
…t to bad media/content types Signed-off-by: Tomáš Kraus <[email protected]>
There was a problem hiding this comment.
I have a 2 questions. :-)
- Why have you decided to drop ParserMode enum, which was used in the 4.x implementation?
- I think I have not seen it also in the 4.x version, but should not these relaxed formats of the content types be also configurable? I mean if user wants to add their own.
| client.get() | ||
| .path("/invalidContentType") | ||
| .request() | ||
| .await(); |
There was a problem hiding this comment.
Please set timeout to the await method.
| client.get() | ||
| .path("/invalidTextContentType") | ||
| .request() | ||
| .await(); |
| WebClientResponse response = client.get() | ||
| .path("/invalidTextContentType") | ||
| .request() | ||
| .await(); |
| assertThat(maybeContentType.get().toString(), is(RELAXED_CONTENT_TYPE_TEXT)); | ||
| } | ||
|
|
||
| private static final String INVALID_CONTENT_TYPE_VALUE = "invalid header value"; |
There was a problem hiding this comment.
constants should be at the top of the class.
| private static final String INVALID_CONTENT_TYPE_VALUE = "invalid header value"; | ||
|
|
||
| // HTTP service with invalid Content-Type | ||
| private static void invalidContentType(ServerRequest request, ServerResponse response) { |
There was a problem hiding this comment.
Move also these static methods under the beforeAll method please. I could not find them when trying to figure out what the endpoint does.
| @Test | ||
| void testInvalidTextContentTypeStrict() { | ||
| try { | ||
| client.get() |
There was a problem hiding this comment.
I think this formatting should be padded.
MediaType in 4.x is rewritten. It's parse method is not public so changing prototype did not cause any issues.
4.x version has hard-coded relaxed format as well. I made it the way jeff requested. This issue is just backport, not any additional enhancement to be done in 3.x only. |
Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus
changed the title
fixes issue #7102
backport of issue #6774 fix