-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate pinning detection to @HelidonTest #9593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Dec 13, 2024
danielkec
force-pushed
the
kec/pinningTest
branch
from
December 15, 2024 20:08
eb33db3
to
43b8fb0
Compare
Signed-off-by: Jorge Bescos Gascon <[email protected]>
danielkec
force-pushed
the
kec/pinningTest
branch
from
December 19, 2024 08:34
7121417
to
2ff7100
Compare
This was
linked to
issues
Dec 19, 2024
tomas-langer
requested changes
Dec 19, 2024
...virtual-threads/src/main/java/io/helidon/common/testing/virtualthreads/PinningException.java
Outdated
Show resolved
Hide resolved
@romain-grecourt please check this PR, I think you are working on some of these classes as well... |
danielkec
force-pushed
the
kec/pinningTest
branch
from
December 19, 2024 10:04
6d84b58
to
10463d2
Compare
* TestNG with always helidon fix Signed-off-by: Daniel Kec <[email protected]>
danielkec
force-pushed
the
kec/pinningTest
branch
from
December 19, 2024 10:24
10463d2
to
906d9dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tomas-langer
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #8877
Fixes:
@HelidonTest
annotation #9603