Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent addition of meters for virtual threads contains code that, when a pinned thread is reported, looks up the previously-registered
Timer
for recent pinned threads so it can update that timer. That look-up logic is flawed because it used the wrong name.There is a
Gauge
for total pinned threads as well as aTimer
for recent pinned threads(recent because as with all distribution summaries the timer's decays over time so "old" pinned thread events might eventually not influence the data).The code that attempted to look up the timer used the gauge's name. Helidon metrics rejected the attempt to look up the gauge as a timer.
This PR corrects the name used for the look-up and also adds the correct
scope
tag and value to the look-up.There is also a new test to make sure the look-up works correctly.
Here is the stack trace before the fix:
Documentation
Bug fix. No doc impact.