Use Helidon gRPC client in Config Etcd module #9674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… V3 servers. V2 support is deprecated and marked for removal. Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
commented
Jan 22, 2025
| @@ -55,7 +55,7 @@ public class EtcdV2Client implements EtcdClient { | |||
| * | |||
| * @deprecated | |||
| */ | |||
| EtcdV2Client(URI... uris) { | |||
| public EtcdV2Client(URI... uris) { | |||
| etcd = new mousio.etcd4j.EtcdClient(uris); | |||
There was a problem hiding this comment.
Needs to be public for IT tests
barchetta
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Helidon gRPC client in config etcd module. Updates old IT tests to run with etcd V3 only. IT tests manually executed and shown to pass with all the latest changes and V3 etcd server. Issue #9650.
Documentation.
None