Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes apparent omission of String.format calls in Http1ConnectionCache.java #9797

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fixes apparent omission of String.format calls in Http1ConnectionCache.java #9797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions webclient/http1/src/main/java/io/helidon/webclient/http1/Http1ConnectionCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,24 +188,24 @@ private boolean finishRequest(LinkedBlockingDeque<TcpClientConnection> connectio
if (connectionQueue.offer(conn, QUEUE_TIMEOUT.toMillis(), TimeUnit.MILLISECONDS)) {
conn.helidonSocket().idle(); // mark it as idle to stay blocked at read for closed conn detection
if (LOGGER.isLoggable(DEBUG)) {
LOGGER.log(DEBUG, "[%s] client connection returned %s",
conn.channelId(),
Thread.currentThread().getName());
LOGGER.log(DEBUG, String.format("[%s] client connection returned %s",
conn.channelId(),
Thread.currentThread().getName()));
}
return true;
} else {
if (LOGGER.isLoggable(DEBUG)) {
LOGGER.log(DEBUG, "[%s] Unable to return client connection because queue is full %s",
conn.channelId(),
Thread.currentThread().getName());
LOGGER.log(DEBUG, String.format("[%s] Unable to return client connection because queue is full %s",
conn.channelId(),
Thread.currentThread().getName()));
}
}
} catch (InterruptedException e) {
if (LOGGER.isLoggable(DEBUG)) {
LOGGER.log(DEBUG, "[%s] Unable to return client connection due to '%s' %s",
conn.channelId(),
e.getMessage(),
Thread.currentThread().getName());
LOGGER.log(DEBUG, String.format("[%s] Unable to return client connection due to '%s' %s",
conn.channelId(),
e.getMessage(),
Thread.currentThread().getName()));
}
}
}
Expand Down
Loading