Apply config setting for built-in meter name case to extended KPI meter names #9800
+151
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er names Signed-off-by: Tim Quinn <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9791
Release Note
Users can set
metrics.built-in-meter-name-formattoCAMEL(the default) orSNAKEto control the case of built-in meter names.Previously, Helidon did not apply this setting to the key performance indicator meters
inFlightandlongRunning. Now it does.PR Overview
The configured case setting is now passed as a parameter when
KeyPerformanceIndicatorMetricsImplsis instantiated so that class (which registers the relevant KPI metrics) can use the selected case style for the meter names when it registers the meters.(One of the extended KPI meters also did not have a description. That's been added.)
The PR includes a new test to make sure the config setting has this effect.
Documentation
Bug fix. No doc impact.