fix: In progress session still has button to 'start implementation' #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a task's spec is approved (status becomes 'spec_approved'), the task is already in the implementation phase. The 'Start Implementation' button should not be visible since implementation has already begun or is about to begin. This fix adds the TaskStatusSpecApproved status to the implementationStarted check in DesignReviewViewer, ensuring the button is hidden when the spec has been approved. Fixes helixml#1433 Signed-off-by: majiayu000 <[email protected]>
prisamuel
approved these changes
Dec 30, 2025
prisamuel
left a comment
prisamuel
left a comment
There was a problem hiding this comment.
thanks for this. Implementation is being auto-triggered by the approval handoff. The start implementation button is redundant here. There was an earlier version where this was manual.
chocobar
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1433
When a task's spec is approved (status becomes
spec_approved), the task is already in the implementation phase. The "Start Implementation" button should not be visible since implementation has already begun or is about to begin.Changes
TaskStatusSpecApprovedstatus to theimplementationStartedcheck inDesignReviewViewer.tsx