Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/220 Grab.app improvement #239

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

Hierosme
Copy link

No description provided.

@Hierosme Hierosme marked this pull request as draft February 10, 2024 15:45
@probonopd
Copy link
Member

What is a "Maj" key? Do you mean "Shift"?

@Hierosme
Copy link
Author

Lol yes that Shift .

Maj is French for Majuscule it mean Capital then Shift

I have write the README this moning with a cafee

@Hierosme
Copy link
Author

Hierosme commented Feb 16, 2024

I have almost finish, it have been really hard.

Unfurtunally, Qt5 do not permit to list Desktop Windows, that is normally possible with Qt6.
Then impossible to take a screen of a specific window by click on it.

Why it have been so hard.

  1. everyone is worng on internet exemple about what is THE screen, THE screen is the parent of the Desktop, and NOT the MainWindow parent. Then the Grab.app have multi monitor support by take screenshot of the Desktop
  2. Nothing is on Qt, then everything is fake ... i have a special transparent widget it take the entire desktop size for get the TRUE Mouse coordinate it match with the screen desktop.
  3. Qt cant get a screenshot with cursor, then i get the Mouse location in my special widget and merge the cursor pixmap with the screen desktop on the exact location
  4. Every exemple on internet is worng about Global Menu size reservation, and that cause a offset when take a selection area screenshot

brief it have been hard but i have almost finish, it just have the final cleanup to do.

@Hierosme
Copy link
Author

Normaly the Grab.app have no capability to edit image.
I really think add a small Paint.app dedecated to it usage.

In any case Gimp.app can deal with specific case, i hope have cover helloSystem users needs when repport a bug.

@louies0623
Copy link
Contributor

#179
We really need a simple Paint.app to handle it, krita is too professional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants