Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add achievement card component #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

faishalirwn
Copy link
Contributor

@faishalirwn faishalirwn commented Jun 13, 2020

Tolong reviewnya,

  • Struktur folder componentnya: di dalem folder components/ dan setiap component punya folder sendiri
  • Stylingnya pake CSS module
    • Next.js kalo pake vanilla css error, katanya style.css harus di dalem _app.js buat global style
    • Storybook biar bisa pake CSS module pake package react-scripts. dapet dari sini

Kendala

Kebanyakan errornya dari aurora. Ngimportnya sesuai repo pake npm link terus di project pake npm link pinoccio (btw namanya pinoccio?)

  • Setiap npm install link pinoccio hilang jd harus npm link pinoccio lagi.

  • Style component2 aurora global, pas ngimport outlineButton semua style component selainnya jg ada di head jadi kadang nama classnya sama terus stylenya numpuk. (atau emang fiturnya gini?)

    • termasuk style font, tapi url fontnya ga bener jd ga bisa langsung pake font 'OpenSans'
      brave_2020-06-13_20-43-48
  • Component outline button dari aurora beda sama di design

  • Component outline button belum di export dari aurora jadi nambah export manual

  • Pas make dev server nextjs yg ngeload page yang ngimport component yg di dalemnya ngimport aurora dapet error window is not defined di file build/main.js aurora. Solve sementara, jgn dulu ngimport, pas page berhasil load baru import, jadi pake hot reload nextjs. Tapi pas reload browser error lagi.

  • Pake SASS ngimport font.scss (atau mungkin scss lain jg?) di style component dapet error di nextjs tapi di storybook lancar. Jadi font belum make 'OpenSans'

@BlinfoldKing
Copy link
Member

ok ntar ku cek duls pinoccio nya

@faishalirwn
Copy link
Contributor Author

bikin componentnya lanjut aja bang pake metode ini?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants