Fix of ListView items dupe on settings reset #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when selected color is black next attempt to change it would be rejected zero is valid for CHOOSECOLOR because COLORREF is A,R,G,B, packed into Int32 additionally skip value updating if it's actually not changed
require 3e8b35b2c08fe9b46607122962451be055eb5fbc for routine
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When settings resets, items in all listviews(and probably any other container-like controls, used to change actual settings) are duped.
Here is a simple fix - listview reset. Note that this fix require henrypp/routine@3e8b35b2 (henrypp/routine#13)
This is a cumulative PR, includes #269