-
Notifications
You must be signed in to change notification settings - Fork 41
Add sound- operation extraction #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sound- operation extraction #1288
Conversation
|
Quite odd that this is worse, I had high hopes for this. I looked into some diffs and honestly I have no idea what's going on, besides the basic idea that this PR creates more rewritable expressions so the node limit is exhausted faster. |
…for-sound--operations
d6aab76 to
f819c03
Compare
|
Alright, an update on this branch. We now achieve better results than |
|
Ok, I think this PR has converged. We now, I believe, are getting results equal to |
This PR adds a new kind of operator within the egraph:
(safe-F x y ... default). The real semantics is that it returns(F x y ...), unless that would crash, in which case it instead returnsdefault. This should be more permissive for rewriting that the currentunsound-Fapproach and should ultimately allow us to solve, say, the quadratic examples again.https://chatgpt.com/codex/tasks/task_e_68521fa019ec833185e3129d9eeb730e