History from JSON #1306
Merged
History from JSON #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a big refactor of
history.rkt, which handles derivations. Previously, this file had two code paths:render-history, which converted an alt to HTML, andrender-json, which converted an alt to JSON. This PR refactors it so that the JSON conversion is primary and the HTML conversion only happens after JSON conversion. This has two benefits. First, previously we were serializing the HTML history and deserializing it; this meant large histories took a very long time. Second, it reduces some duplication, and in general makes the code clearer since you don't need to worry about updating the JSON or not.