Skip to content

Conversation

@noahhuck
Copy link
Collaborator

@noahhuck noahhuck commented Nov 2, 2025

Updates egglog to the 1.0.0 release. Some changes to the nightly script to make sure that the Cargo version is high enough.

@noahhuck noahhuck requested a review from pavpanchekha November 2, 2025 03:23
@pavpanchekha
Copy link
Contributor

The PR is good but one thing I want to mention is, the default backend isn't egglog, it's egg. So we're not actually running egglog in nightly. If you're certain the output works unchanged I guess I can handle that but maybe you want to temporarily add --enable generate:egglog as an argument to the nightly script, so we can test the egglog backend.

@noahhuck
Copy link
Collaborator Author

noahhuck commented Nov 3, 2025

The PR is good but one thing I want to mention is, the default backend isn't egglog, it's egg. So we're not actually running egglog in nightly. If you're certain the output works unchanged I guess I can handle that but maybe you want to temporarily add --enable generate:egglog as an argument to the nightly script, so we can test the egglog backend.

Good point, I was just making sure nightly worked as before. I did some local testing but I'll run a nightly with that enabled to get better coverage.

@pavpanchekha
Copy link
Contributor

Great, should be enough to just add that flag to the makefile temporarily

@pavpanchekha
Copy link
Contributor

Nightly is good, please undo the command switch but after that go ahead and merge.

@noahhuck noahhuck merged commit e9e9760 into main Nov 4, 2025
6 checks passed
@pavpanchekha pavpanchekha deleted the update-egglog branch November 4, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants