Drop sound-X operations with rewrites
#1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 'unsound schedule phase that runs sound-removal rules - Updated schedules in patch.rkt to use new symbolic format - Added 'unsound to allowed schedule steps in make-egraph Amp-Thread-ID: https://ampcode.com/threads/T-22bbca62-e422-4650-82bc-3c6001085627 Co-authored-by: Amp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we guarantee rewrite soundness using rules called
sound-/,sound-log, andsound-pow. But then in lowering we currently have duplicate lowering rules with and without thesound-prefix. This is ugly, so this PR instead replaces it with three rules that drop thesound-part of the operation and run in a separate rewrite step. It should be simpler and cleaner, and also easier to add to egglog when the time comes.