Remove the iter-limit for lift/lower passes #1417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack unsoundness Amp-Thread-ID: https://ampcode.com/threads/T-e42e0d11-8b3d-4fb6-a740-47e0708ed68f Co-authored-by: Amp <[email protected]>
Contributor
Author
|
Huh, this was actually a disaster, super duper slow. Why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is that lifting and lowering never need more than one iteration, so we should just run them until saturation. I also turn off stop reason logging for these passes (since they always saturate). Unrelatedly, I also make unsoundness louder (always log) basically because I'm hoping to discover we are never unsound and, if so, remove the whole unsoundness handling code.