WIP: Only run Taylor on the last iteration #1418
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Taylor to only run on the last iteration. The code is ugly because I don't really expect it to work.
The basic thesis here is that Taylor is usually only needed once (multiple iterations might approximate away multiple variable but that doesn't seem common?) and that if you do it too early (iteration 1) it might gate off multi-iteration rewrites due to greediness. Frankly we've tried this before and it didn't work, but there have been recent bug fixes in rewrites that make me think that maybe it will work this time.